Skip to content

fix: avoid rollback during loop auto-reject#257

Closed
firstdraft-work wants to merge 1 commit intoEvoMap:mainfrom
firstdraft-work:codex/upstream-loop-autoreject-safety
Closed

fix: avoid rollback during loop auto-reject#257
firstdraft-work wants to merge 1 commit intoEvoMap:mainfrom
firstdraft-work:codex/upstream-loop-autoreject-safety

Conversation

@firstdraft-work
Copy link
Contributor

Summary

  • stop loop-mode auto-reject from running a full git checkout/clean on the repository
  • keep the pending-run deadlock fix by marking the run rejected in solidify state only
  • add a regression test covering state-only auto-reject and preservation of untracked files

Testing

  • node --test

@autogame-17
Copy link
Collaborator

Thank you @firstdraft-work for this contribution! The changes have been reviewed and merged into the upstream codebase with full Co-authored-by attribution.

The fix correctly removes the destructive git checkout -- . and git clean -fd from rejectPendingRun, which could inadvertently delete untracked work files during loop-mode auto-reject. The state-only rejection approach is the right design.

Your improvement will be included in the next public release.

If you have an EvoMap account, we would like to award you credits for this contribution. Please reply with your node_id or registered email so we can send the reward.

Closing this PR as the changes have been cherry-picked upstream (the public repo is a one-way publish from the private codebase). Thanks again!

@firstdraft-work
Copy link
Contributor Author

Thank you @firstdraft-work for this contribution! The changes have been reviewed and merged into the upstream codebase with full Co-authored-by attribution.

The fix correctly removes the destructive git checkout -- . and git clean -fd from rejectPendingRun, which could inadvertently delete untracked work files during loop-mode auto-reject. The state-only rejection approach is the right design.

Your improvement will be included in the next public release.

If you have an EvoMap account, we would like to award you credits for this contribution. Please reply with your node_id or registered email so we can send the reward.

Closing this PR as the changes have been cherry-picked upstream (the public repo is a one-way publish from the private codebase). Thanks again!

thx! my node_id: node_f709a85a

@autogame-17
Copy link
Collaborator

@firstdraft-work 100 credits have been awarded to your account (node_f709a85a). Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants